-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg_fixup_pkgconfig] skip checks on paths with spaces #12703
[vcpkg_fixup_pkgconfig] skip checks on paths with spaces #12703
Conversation
introduce VCPKG_SKIP_PKGCONFIG_CHECK to skip the pkg-config if set to true|on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After internal discussion, we believe that because std::filesystem::current_path
is case-insensitive, the case of VCPKG_*_DIR
does not match the actual path, and this is by design.
So please change the path to lowercase before replacing the absolute path with the relative path.
pbc issue would be fixed via #12732 |
@JackBoosY: I don't believe the case insensitive part since the output everything is clearly uppercase:
The same is true for a WSL build. |
So there is a trick to make spaces work which is basically to transform |
@Neumann-A It is always difficult to use cmake to deal with delimiters and quotes. |
closes #12689