Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpu-features] Add new port #12681

Merged
merged 5 commits into from
Aug 31, 2020
Merged

[cpu-features] Add new port #12681

merged 5 commits into from
Aug 31, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Aug 1, 2020

Describe the pull request

@PhoebeHui PhoebeHui self-assigned this Aug 3, 2020
@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 3, 2020
@PhoebeHui
Copy link
Contributor

@myd7349, thanks for the PR!

Could you take a look at the failures on arm64-windows, arm-uwp and x64-uwp? if the triplets doesn't support, could you add them to 'Supports'?

@myd7349
Copy link
Contributor Author

myd7349 commented Aug 6, 2020

@myd7349, thanks for the PR!

Could you take a look at the failures on arm64-windows, arm-uwp and x64-uwp? if the triplets doesn't support, could you add them to 'Supports'?

Thanks. I will look into it this weekend.

@myd7349 myd7349 marked this pull request as ready for review August 8, 2020 06:36
@PhoebeHui
Copy link
Contributor

PhoebeHui commented Aug 10, 2020

@myd7349, you only need to add arm and uwp to 'Supports', could you please remove them from ci.baseline file?

For the json file check failed in CI pipeline, you can use ./vcpkg x-format-manifest --all to format the json file.

@myd7349
Copy link
Contributor Author

myd7349 commented Aug 18, 2020

@myd7349, you only need to add arm and uwp to 'Supports', could you please remove them from ci.baseline file?

For the json file check failed in CI pipeline, you can use ./vcpkg x-format-manifest --all to format the json file.

Hi @PhoebeHui Thanks. Done!

@PhoebeHui PhoebeHui added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response labels Aug 31, 2020
@PhoebeHui
Copy link
Contributor

All features test passed on x64-windows and x64-linux.

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Aug 31, 2020
@BillyONeal BillyONeal merged commit b9da397 into microsoft:master Aug 31, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@myd7349 myd7349 deleted the cpu-features branch September 1, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants