Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[winpcap] Remove the keyword 'inline' macro #12542

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

PhoebeHui
Copy link
Contributor

Closes #10730

winpcap's header file pcap-stdinc.h contains '#define inline _inline', which cause the following failures when use the headers on vs2019. Remove the macro for unblocking the usage.

fatal error C1189: #error: The C++ Standard Library forbids macroizing the keyword "inline". Enable warning C4005 to find the forbidden define.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 23, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review July 24, 2020 01:55
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 31, 2020
@strega-nil strega-nil merged commit ca93b65 into microsoft:master Jul 31, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/winpcap branch August 11, 2020 01:59
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [winpcap] Remove the keyword 'inline' macro

* Restrict the keyword macro in C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling against winpcap on a recent Visual Studio fails
4 participants