-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg formatting] Turn off DeriveLineEnding #12368
Conversation
Adding to the discussion, what about doing the same thing (and enforcing the rule with .gitattributes) also for port files, control files and patches? |
We do like standardization, but we also don't want to waste people's time; an important factor that significantly reduces costs of imposing LF on code is that clang-format will automatically correct the issue without users even noticing (which we already require contributors to run anyway). I think that before we move to enforce such conventions on port files, we should seek to have tooling that will automatically fix i t. |
isn't it possible to do it using git & enforcing gitattributes file? (that would have been true also for cpp files) |
Since we're reformatting anyways
* [vcpkg formatting] Turn off DeriveLineEnding * format * Add newlines to the end of files Since we're reformatting anyways
This PR removes CRLFs from existing C++ files, and standardizes upon the line ending
\n
.This is not necessarily a thing we wish to do, so I'm labelling it requires:discussion.