Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mingw port fixes #12103

Merged
merged 7 commits into from
Jul 31, 2020
Merged

Mingw port fixes #12103

merged 7 commits into from
Jul 31, 2020

Conversation

koprok
Copy link
Contributor

@koprok koprok commented Jun 25, 2020 •
edited
Loading

  • Fix MinGW build of following ports: openal-soft, glew, protobuf
  • Update protobuf to 3.12.3

@longnguyen2004
Copy link
Contributor

longnguyen2004 commented Jun 25, 2020 •
edited
Loading

mingw is currently static only so import libs check is already disabled internally in vcpkg (or am I wrong here?)
It would be useful for dynamic triplets tho, which I'm planning to add in #12101

@koprok
Copy link
Contributor Author

koprok commented Jun 25, 2020

Uhh since mingw is currently static only so import libs check is already disabled internally in vcpkg (or am I wrong here?)
It would be useful for dynamic triplets tho, which I'm planning to add in #12101

@longnguyen2004 you are right, I will remove this commit.

@koprok koprok force-pushed the mingw-port-fixes branch from 7f1de33 to d100cca Compare June 25, 2020 11:21
@koprok koprok force-pushed the mingw-port-fixes branch from d100cca to 5c177f2 Compare June 26, 2020 10:44
@JackBoosY JackBoosY self-assigned this Jun 28, 2020
JackBoosY
JackBoosY suggested changes Jun 28, 2020
View reviewed changes
@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 28, 2020
@koprok koprok requested a review from JackBoosY June 29, 2020 07:55
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 29, 2020
ras0219-msft
ras0219-msft approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the conditional to better reflect existing behavior -- LGTM once the build passes again :)

@JackBoosY
Copy link
Contributor

Passed.

@JackBoosY
Copy link
Contributor

JackBoosY commented Jul 17, 2020 •
edited
Loading 

D:\buildtrees\magnum-plugins\src\v2020.06-f0c46dc4fa.clean\src\MagnumPlugins\StbImageImporter\StbImageImporter.cpp(91): error C3861: 'stbi_set_flip_vertically_on_load_thread': identifier not found
D:\buildtrees\magnum-plugins\src\v2020.06-f0c46dc4fa.clean\src\MagnumPlugins\StbImageImporter\StbImageImporter.cpp(95): error C3861: 'stbi_convert_iphone_png_to_rgb_thread': identifier not found

Conflict with port stb, will fix in other PR.

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Jul 17, 2020
@JackBoosY JackBoosY mentioned this pull request Jul 17, 2020
Merged
@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jul 17, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit fe19c5e into microsoft:master Jul 31, 2020
@koprok koprok deleted the mingw-port-fixes branch August 3, 2020 07:06
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@koprok @ras0219-msft
@JackBoosY @hellozee
Mingw port fixes (microsoft#12103)
a69ea80 
* [openal-soft] MinGW build fixes

* [glew] MinGW build fixes

* [protobuf] MinGW build fixes

* [protobuf] Update to 3.12.3

* [protobuf] Preserve existing cross-compilation behavior (e.g. android)

Co-authored-by: Robert Schumacher <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koprok @longnguyen2004 @JackBoosY @strega-nil @ras0219-msft