-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[getdns] Add new port. #12090
[getdns] Add new port. #12090
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The failures on x64-uwp and arm-uwp triplets:
Could you please look into this and try to fix it? |
There's at least one Win32 API being used in GetDNS which is not supported in UWP. I don't have time to properly investigate and correct this myself right now, so for the moment I've marked it as not supported under UWP and filed a bug with upstream. |
Have you tested these features? Can these work well? |
LGTM, thanks for the PR! |
[getdns] Add new port. (microsoft#12090)
Add new port for getdns (https://getdnsapi.net).
What does your PR fix? Fixes [New Port Request] getdns #12075
Which triplets are supported/not supported? Have you updated the CI baseline?
All CI failures appear to be in other packages. I have verified
x64-windows
,x86-windows
,x64-windows-static
andx86-windows-static
build.Does your PR follow the maintainer guide?
I think so. Two of the 3 patches applied are submitted upstream, the other is waiting for a response from the chief maintainer on whether it's a CMakeLists.txt problem or a packaging problem.