Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Use SSH keys instead of password authentication when minting Linux scale sets #11999

Merged
merged 6 commits into from
Jun 22, 2020
Merged

[vcpkg] Use SSH keys instead of password authentication when minting Linux scale sets #11999

merged 6 commits into from
Jun 22, 2020

Conversation

BillyONeal
Copy link
Member

This is required by a future Azure DevDiv security policy which will fail VM creations that don't disable password auth.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre depends:vm-update PR contains changes to the VM provisioning scripts labels Jun 18, 2020
@BillyONeal BillyONeal requested a review from strega-nil June 18, 2020 02:38
@strega-nil
Copy link
Contributor

I would really prefer if we minted an ssh key and then threw it away, like we do for Windows passwords

@BillyONeal
Copy link
Member Author

Me too but Powershell has no such capability and I don't want to require someone run this in a prompt with openssh tools on the PATH.

@strega-nil
Copy link
Contributor

Why not? Aren't they automatically on the path pretty much everywhere?

@BillyONeal
Copy link
Member Author

I don't think that's a default Windows component?

@strega-nil
Copy link
Contributor

strega-nil commented Jun 18, 2020 •
edited
Loading

Pretty sure; it's in C:\Windows\System32 for me, so it's at least an optional component, and I don't remember turning it on.

Edit: Yeah, it's definitely a default component. It's on the path on my (non-developer) fiancée's laptop.

@BillyONeal
Copy link
Member Author

settings page

It's listed as an optional feature but no idea what the default is. ¯\_(ツ)_/¯. I guess installing that might be less annoying than needing to generate a key in advance...

strega-nil
strega-nil suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes :)

@BillyONeal BillyONeal requested a review from strega-nil June 19, 2020 04:13
@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal merged commit 2bf1f30 into microsoft:master Jun 22, 2020
@BillyONeal BillyONeal deleted the ssh-keys branch June 22, 2020 02:13
@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 22, 2020
cenit pushed a commit to cenit/vcpkg that referenced this pull request Jun 22, 2020
@BillyONeal @cenit
[vcpkg] Use SSH keys instead of password authentication when minting …
f5bf3d6 
…Linux scale sets (microsoft#11999)
@Jimmy-Hu Jimmy-Hu mentioned this pull request Jun 22, 2020
Merged
strega-nil pushed a commit that referenced this pull request Jul 28, 2020
@cenit @BillyONeal @JackBoosY
[opencv4] update to v4.3 (#11130)
f1e7a3f 
* [opencv4] draft update to v4.3

* restore uwp patch

* fix qt and ipp features

* fix libepoxy and meson on osx

* fix baseline, trigger a full rebuild due to meson tool changes

* remove jpeg feature on windows due to a bug with MSVC

* minor fixes for some features

* ffmpeg x11 lib not required anymore on apple for downstream projects

* small fixes for ogre and qt5

* remove a broken module

* fix installation path

* fix openexr which was broken and regressed opencv downstream projects

* first round of ci passes

* improve compatibility with android toolchain

* [openexr] upgrade to v2.5.0 to fix regressions, might require fixes in dependent projects and might deserve its own PR

* fix OpenEXR link for downstream projects

* do not install unrequested features

* fix compatibility with newer OpenEXR

* [OpenCV3] update to v3.4.10

* fix openexr on windows, was creating symlinks that broke vcpkg

* fix openexr wrapper

* [openexr] cmake config files are installed into a lowered-case folder

* remove mangled paths trying to fix android setup

* disable dnn on android, fix mangled cmake config paths again

* fix downstream CUDA dependency

* fix compatibility with vs16.6

* remove from baseline ports now passing tests

* [alembic] fixes for new openexr

* fix baseline

* [field3d] fixes for new openexr

* [field3d] improve fixes, windows still unsupported despite what is said upstream

* apply fixes required from review

* add missing field3d patch

* [field3d] disable mpi integration

* [opencv2] remove cublas integration

* [vtk] do not create libharu::libharu target if already existing

* Update ports/opencv4/portfile.cmake

Co-authored-by: Jack·Boos·Yu <[email protected]>

* Update ports/opencv3/portfile.cmake

Co-authored-by: Jack·Boos·Yu <[email protected]>

* improve compatibility with newer CUDNN

* [OpenCV3, OpenCV4] improve compatibility with CUDA 11

* [OpenCV2] improve compatibility with CUDA 11

* [field3d] regenerate patch ignoring space at eol

* [vcpkg] Use SSH keys instead of password authentication when minting Linux scale sets (#11999)

* [field3d] regenerate patch ignoring space at eol

* [field3d] regenerate patch, again

* [field3d] fixes for windows

* [libass] fix regression

* ci.baseline.txt update

* [CUDA11] use FindCUDA from CMake 3.18 to ease transition later

* re-bump vtk and ffmpeg, which were lost with merges from master

* [OpenCV4] Halide feature is not broken anymore

* [field3d] regenerate hdf5 patch

* [OpenCV4] remove GTK features: it can be built only on *nix but GTK on vcpkg cannot be built on *nix systems...

* merge ci.baseline.txt from master and fix field3d patch

* remove rebuilding

* restore vtk CONTROL file

* update CONTROL files

* Trigger rebuild

* Update ports/freeimage/CONTROL

* Update ports/freeimage/CONTROL

* [opencv3/4] avoid tesseract dependency on uwp builds

* [opencv] add missing module search

Co-authored-by: Billy Robert O'Neal III <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@cenit @BillyONeal
@JackBoosY @hellozee
[opencv4] update to v4.3 (microsoft#11130)
3ca1fa8 
* [opencv4] draft update to v4.3

* restore uwp patch

* fix qt and ipp features

* fix libepoxy and meson on osx

* fix baseline, trigger a full rebuild due to meson tool changes

* remove jpeg feature on windows due to a bug with MSVC

* minor fixes for some features

* ffmpeg x11 lib not required anymore on apple for downstream projects

* small fixes for ogre and qt5

* remove a broken module

* fix installation path

* fix openexr which was broken and regressed opencv downstream projects

* first round of ci passes

* improve compatibility with android toolchain

* [openexr] upgrade to v2.5.0 to fix regressions, might require fixes in dependent projects and might deserve its own PR

* fix OpenEXR link for downstream projects

* do not install unrequested features

* fix compatibility with newer OpenEXR

* [OpenCV3] update to v3.4.10

* fix openexr on windows, was creating symlinks that broke vcpkg

* fix openexr wrapper

* [openexr] cmake config files are installed into a lowered-case folder

* remove mangled paths trying to fix android setup

* disable dnn on android, fix mangled cmake config paths again

* fix downstream CUDA dependency

* fix compatibility with vs16.6

* remove from baseline ports now passing tests

* [alembic] fixes for new openexr

* fix baseline

* [field3d] fixes for new openexr

* [field3d] improve fixes, windows still unsupported despite what is said upstream

* apply fixes required from review

* add missing field3d patch

* [field3d] disable mpi integration

* [opencv2] remove cublas integration

* [vtk] do not create libharu::libharu target if already existing

* Update ports/opencv4/portfile.cmake

Co-authored-by: Jack·Boos·Yu <[email protected]>

* Update ports/opencv3/portfile.cmake

Co-authored-by: Jack·Boos·Yu <[email protected]>

* improve compatibility with newer CUDNN

* [OpenCV3, OpenCV4] improve compatibility with CUDA 11

* [OpenCV2] improve compatibility with CUDA 11

* [field3d] regenerate patch ignoring space at eol

* [vcpkg] Use SSH keys instead of password authentication when minting Linux scale sets (microsoft#11999)

* [field3d] regenerate patch ignoring space at eol

* [field3d] regenerate patch, again

* [field3d] fixes for windows

* [libass] fix regression

* ci.baseline.txt update

* [CUDA11] use FindCUDA from CMake 3.18 to ease transition later

* re-bump vtk and ffmpeg, which were lost with merges from master

* [OpenCV4] Halide feature is not broken anymore

* [field3d] regenerate hdf5 patch

* [OpenCV4] remove GTK features: it can be built only on *nix but GTK on vcpkg cannot be built on *nix systems...

* merge ci.baseline.txt from master and fix field3d patch

* remove rebuilding

* restore vtk CONTROL file

* update CONTROL files

* Trigger rebuild

* Update ports/freeimage/CONTROL

* Update ports/freeimage/CONTROL

* [opencv3/4] avoid tesseract dependency on uwp builds

* [opencv] add missing module search

Co-authored-by: Billy Robert O'Neal III <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyONeal @strega-nil @PhoebeHui