Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libiconv port #118

Merged
merged 1 commit into from
Oct 5, 2016
Merged

add libiconv port #118

merged 1 commit into from
Oct 5, 2016

Conversation

emmatyping
Copy link
Contributor

Here is a working port of libiconv.

Potential issues (not really road blockers more of style):

  • patch instead of using a custom file? I chose to use a custom file as the config.in since the file() command in CMake doesn't overwrite filenames. The vcpkg apply patch doesn't seem to work as it takes the out parameter as an input parameter (I can file an issue on this), and overwriting the file doesn't require git.
  • patch-ify everything? The idea being that one patch would need to be applied instead of several copy commands.

I can adjust this PR based on your feedback.

@msftclas
Copy link

msftclas commented Oct 5, 2016

Hi @ethanhs, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Oct 5, 2016

@ethanhs, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@ras0219-msft
Copy link
Contributor

This looks pretty perfect as-is 👍 . My thoughts are

  • If you only need to add files, don't use a patch.
  • Do not modify files by checking in a modified copy -- always use a patch.
  • If you need to add files and modify files, you're welcome to select the mix that works the best for you (I generally find patches easier to work with in this case).

@ras0219-msft ras0219-msft merged commit 7a90372 into microsoft:master Oct 5, 2016
@emmatyping emmatyping mentioned this pull request Oct 5, 2016
@emmatyping emmatyping changed the title WIP: add libiconv port add libiconv port Oct 5, 2016
@emmatyping
Copy link
Contributor Author

Thanks. I will start working on a libxml2 port with those guidelines in mind.

JoergAtGithub pushed a commit to JoergAtGithub/vcpkg that referenced this pull request Feb 26, 2024
Add support for building 2.5 environment with Qt 5 via optional `qt5` feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants