[vcpkg] Resolve --overlay-ports is only working for relative parths since fix… #11302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
changed the title
|
I tried the fix, it works well, thank you for the PR! |
PhoebeHui
approved these changes
May 11, 2020
|
The osx failure doesn't relate to this change. please ignore it. |
|
@PhoebeHui when will it be possible to merge this change? since saturday no builds in our company are working because of this bug |
|
Cool, thanks @TobiasFunk :) |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…ince fix… (microsoft#11302) * Resolve --overlay-ports is only working for relative parths since fix for microsoft#10771 Fixes microsoft#11301 * use auto instead of fs::path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for
Fixes #11301
Describe the pull request
Since the fix #10771 the --overlay-ports parameter does not work with absolute paths any more.
What does your PR fix? Fixes issue #
Fixes: install using --overlay-ports results in error (error getting status of path) #11301
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?