Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] #11129: Add VCPKG_LINKER_FLAGS_<CONFIG>. #11290

Merged
merged 6 commits into from
Sep 3, 2020
Merged

[vcpkg] #11129: Add VCPKG_LINKER_FLAGS_<CONFIG>. #11290

merged 6 commits into from
Sep 3, 2020

Conversation

psfrolov
Copy link
Contributor

Resolves issue #11129.

@msftclas
Copy link

msftclas commented May 10, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui changed the title #11129: Add VCPKG_LINKER_FLAGS_<CONFIG>. [vcpkg] #11129: Add VCPKG_LINKER_FLAGS_<CONFIG>. May 15, 2020
@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jun 11, 2020
@Septarius Septarius mentioned this pull request Jun 13, 2020
Closed
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms
Copy link
Member

vicroms commented Jul 2, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 13, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

These regressions will be fixed in another PR.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 5, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

This regression will be solved in #13125.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Aug 27, 2020
@BillyONeal
Copy link
Member

Looks like the x64_uwp regressions are sourceforge servers being down

@BillyONeal
Copy link
Member

Looks like the SourceForge bits are fixed by #13176

@BillyONeal BillyONeal mentioned this pull request Aug 28, 2020
Merged
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 28, 2020
@BillyONeal BillyONeal merged commit 6c7f2d9 into microsoft:master Sep 3, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@psfrolov psfrolov deleted the #11129 branch September 3, 2020 19:39
@JackBoosY JackBoosY mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@BillyONeal BillyONeal BillyONeal approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@psfrolov @msftclas @BillyONeal @JackBoosY @vicroms @strega-nil @ras0219-msft @Neumann-A @PhoebeHui