-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[magnum] fixes adding any feature that depends on any other feature it will enable all the defaults #11225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please bump the version as 2019.10-2
?
@NancyLi1013 done |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Feature
Features
|
Hi @fran6co |
@NancyLi1013 done about the conflicts, not sure about the other errors. This change shouldn't have caused that |
@fran6co
Do these problems have resolved? |
Where do you see those errors? I can't reproduce them |
When building features, I encountered these errors. |
@fran6co |
@fran6co |
No, sorry. I don't have time to check it out |
Thanks for your update. You can reopen this if you want to continue working for this PR. |
939b97a
to
711d94d
Compare
I got it to compile no problem on a Windows machine, x64 and x86 with |
Let's wait for the CI checks. |
Cool, thanks @fran6co :) |
vcpkg install magnum[core,shaders]
will install all the default features instead of justgl
Related to issue #11097