Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[magnum] fixes adding any feature that depends on any other feature it will enable all the defaults #11225

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented May 7, 2020

vcpkg install magnum[core,shaders] will install all the default features instead of just gl

Related to issue #11097

Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the version as 2019.10-2?

@fran6co
Copy link
Contributor Author

fran6co commented May 8, 2020

@NancyLi1013 done

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 15, 2020

Feature windowlessglxapplication failed on x86-windows:

CMake Error at src/Magnum/Platform/CMakeLists.txt:515 (message):
  X11 library, required by some applications, was not found.  Set
  WITH_*X*APPLICATION to OFF to skip building them.

Features eglcontext, cglcontext , glxcontext , wglcontext ,glfwapplication , Sdl2Application , windowlesseglapplication , windowlessglxapplication failed on x86-windows:

-- Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) 
CMake Error at src/Magnum/Platform/CMakeLists.txt:833 (message):
  EGL library, required by some contexts, was not found.  Set
  WITH_*APPLICATION and/or WITH_EGLCONTEXT to OFF to skip building them.

@NancyLi1013
Copy link
Contributor

Hi @fran6co
Could you please resolve the conflicts?

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 22, 2020
@fran6co
Copy link
Contributor Author

fran6co commented May 24, 2020

@NancyLi1013 done about the conflicts, not sure about the other errors. This change shouldn't have caused that

@NancyLi1013
Copy link
Contributor

@fran6co
Sorry for the late reply.

Feature windowlessglxapplication failed on x86-windows:

CMake Error at src/Magnum/Platform/CMakeLists.txt:515 (message):
  X11 library, required by some applications, was not found.  Set
  WITH_*X*APPLICATION to OFF to skip building them.

Features eglcontext, cglcontext , glxcontext , wglcontext ,glfwapplication , Sdl2Application , windowlesseglapplication , windowlessglxapplication failed on x86-windows:

-- Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) 
CMake Error at src/Magnum/Platform/CMakeLists.txt:833 (message):
  EGL library, required by some contexts, was not found.  Set
  WITH_*APPLICATION and/or WITH_EGLCONTEXT to OFF to skip building them.

Do these problems have resolved?

@fran6co
Copy link
Contributor Author

fran6co commented Jun 17, 2020

@fran6co
Sorry for the late reply.

Feature windowlessglxapplication failed on x86-windows:

CMake Error at src/Magnum/Platform/CMakeLists.txt:515 (message):
  X11 library, required by some applications, was not found.  Set
  WITH_*X*APPLICATION to OFF to skip building them.

Features eglcontext, cglcontext , glxcontext , wglcontext ,glfwapplication , Sdl2Application , windowlesseglapplication , windowlessglxapplication failed on x86-windows:

-- Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) 
CMake Error at src/Magnum/Platform/CMakeLists.txt:833 (message):
  EGL library, required by some contexts, was not found.  Set
  WITH_*APPLICATION and/or WITH_EGLCONTEXT to OFF to skip building them.

Do these problems have resolved?

Where do you see those errors? I can't reproduce them

@NancyLi1013
Copy link
Contributor

When building features, I encountered these errors.
Can these features build successfully on your machine?

@NancyLi1013
Copy link
Contributor

@fran6co
Could you please resolve the conflicts?

@NancyLi1013
Copy link
Contributor

@fran6co
Is work still being done for this PR?

@fran6co
Copy link
Contributor Author

fran6co commented Jul 23, 2020

No, sorry. I don't have time to check it out

@fran6co fran6co closed this Jul 23, 2020
@NancyLi1013
Copy link
Contributor

Thanks for your update. You can reopen this if you want to continue working for this PR.

@fran6co
Copy link
Contributor Author

fran6co commented Nov 24, 2020

When building features, I encountered these errors.
Can these features build successfully on your machine?

I got it to compile no problem on a Windows machine, x64 and x86 with vcpkg.exe install --recurse magnum[core,windowlessglxapplication] and the other features as well

@NancyLi1013
Copy link
Contributor

Let's wait for the CI checks.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 1, 2020
@strega-nil strega-nil merged commit 6b19f55 into microsoft:master Dec 1, 2020
@strega-nil
Copy link
Contributor

Cool, thanks @fran6co :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants