Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[harfbuzz] Request feature "experimental_api" #38181

Closed
wyzdwdz opened this issue Apr 14, 2024 · 0 comments · Fixed by #38182
Closed

[harfbuzz] Request feature "experimental_api" #38181

wyzdwdz opened this issue Apr 14, 2024 · 0 comments · Fixed by #38182
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@wyzdwdz
Copy link
Contributor

wyzdwdz commented Apr 14, 2024

Is your feature request related to a problem? Please describe.

I want to use this API

https://github.com/harfbuzz/harfbuzz/blob/39b5ae79f0e4018ecb004c1a27d6c9f16492f5a5/src/hb-subset.h#L207C1-L214C39

but it is only enabled when HB_EXPERIMENTAL_API is defined

Proposed solution

https://github.com/harfbuzz/harfbuzz/blob/39b5ae79f0e4018ecb004c1a27d6c9f16492f5a5/meson_options.txt#L43-L44

meson option "experimental_api" will control HB_EXPERIMENTAL_API

Describe alternatives you've considered

No response

Additional context

No response

@wyzdwdz wyzdwdz added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 14, 2024
JavierMatosD pushed a commit that referenced this issue Apr 18, 2024
Fixes #38181.

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

Add new CMake target `harfbuzz::harfbuzz-subset` and new feature
`experimental-api`

---------

Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: Jon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants