Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-build validation fails if VS is not installed in "C:\Program Files (x86)\Microsoft Visual Studio 14.0\"" #37

Closed
Remotion opened this issue Sep 20, 2016 · 1 comment

Comments

@Remotion
Copy link

Remotion commented Sep 20, 2016

post-build validation fails if VS is not installed in "C:\Program Files (x86)\Microsoft Visual Studio 14.0""
But this is common if SSD for windows it too small.

Apparently because of this line hard coded path.

static const fs::path DUMPBIN_EXE = R"(C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\dumpbin.exe)";

%VS140COMNTOOLS% should be used instate.

@ras0219-msft
Copy link
Contributor

Fixed by #38, thanks for reporting this!

strega-nil pushed a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
'git fetch' normally refuses to deal with shallow repositories.
For vcpkg, this makes it impossible to use shallow clones of remote
registries such as 'VCPKG_INSTALLATION_ROOT' on Azure Pipelines.
An extra parameter makes 'git fetch' accept shallow repositories.
strega-nil added a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
The following PRs are included:

* hopefully fix crash in constraints (microsoft#60)
* [vcpkg] allow --version to check the version (microsoft#50)
* Remove baseline warning (microsoft#27)
* [git] always pass autocrlf=false (microsoft#58)
* ignore QtCreator CMake project files (microsoft#54)
* ignore .DS_store files (microsoft#53)
* [vcpkg] x-add-version now also checks if the manifest file is properly formatted (microsoft#43)
* hopefully fix ci issue microsoft#16773 (microsoft#34)
* Add docs to set VCPKG_ROOT to run tests (microsoft#45)
* [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (microsoft#44)
* add clang-format version to format-cxxcode (microsoft#41)
* [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (microsoft#40)
* [supports] Add `native` identifier expression and x-check-support command (microsoft#29)
* [metrics] Split reporting of installs into name:triplet (microsoft#39)
* [vcpkg] Improve error when accessing missing feature (microsoft#38)
* [vcpkg] Allow shallow git registries (microsoft#37)
* Disable git autocrlf when archiving tree (microsoft#36)
* Use only named packages from extra registries (microsoft#35)
* [registries] add metrics (microsoft#30)
* Add vcpkg policy cmake helper port support (microsoft#17)
* [osx] add support for rosetta (microsoft#23)
* don't build tls12-download unless it's needed (microsoft#33)
* Add new telemetry points for versioning (microsoft#21)
* add cmake_minimum_required to vcpkg_tags (microsoft#25)
* [x-add-versions] Perform atomic replacement of versioning files (microsoft#28)
* [tools] support gsutil (microsoft#19)
* add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26)
* Add finite timeout on CURL metrics endpoint. (microsoft#22)
* fix UB in make_error_code(utf8_errc) (microsoft#18)
JoergAtGithub pushed a commit to JoergAtGithub/vcpkg that referenced this issue Jul 2, 2022
dempo93 pushed a commit to dempo93/vcpkg that referenced this issue Aug 23, 2022
Merging branch related to issue microsoft#33: add TreeNode::onInit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants