Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] Move to CMake #32274

Closed
1 task done
Neumann-A opened this issue Jun 28, 2023 · 2 comments · Fixed by #32309
Closed
1 task done

[boost] Move to CMake #32274

Neumann-A opened this issue Jun 28, 2023 · 2 comments · Fixed by #32309
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@Neumann-A
Copy link
Contributor

Neumann-A commented Jun 28, 2023

Is your feature request related to a problem? Please describe.

Is your feature request related to a problem?

Not really. just following the maintainer guides to prefer CMake over all else. and the current b2 hacks vcpkg uses generate problems. CMake is easier to maintain from a vcpkg perspective since more people know how to use it correctly.

Proposed solution

Currently boost only provides a monolithic build system which is either b2 or cmake. vcpkg currently hacks something together with b2 rules. I propose to hack something together with CMake instead since boost will then provide cmake config files which are better and easier to consume then using cmakes FindBoost.
The main problems:

  • cmake build is monolithic, superporject build
  • sublibs have no install rules
  • sublibs do not generate a config
  • sublibs do not have find_package calls.

However:

As such vcpkg should probably switch to using CMake for boost in the future.

Describe alternatives you've considered

Stay with b2 and fight stuff like #27694 (not really and option ;))

Additional context

No response

Tasks

Preview Give feedback
  1. category:port-feature info:reviewed
    Cheney-W
@Neumann-A Neumann-A added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 28, 2023
@JavierMatosD JavierMatosD self-assigned this Jun 29, 2023
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Dec 27, 2023
@Neumann-A
Copy link
Contributor Author

not stale

@github-actions github-actions bot removed the Stale label Jan 3, 2024
JavierMatosD pushed a commit that referenced this issue Apr 29, 2024
~~arm64-windows: boost-context builds are blocked by a cmake bug (see
https://gitlab.kitware.com/cmake/cmake/-/issues/24317)~~

closes #32274
closes Neumann-A/my-vcpkg-triplets#5

Questions:
- [x] ~~Move cmake files to `share/cmake/<name>` ?~~ Not doing it
because it is just using `vcpkg_cmake_config_fixup()`
- [x] Fix weak dependencies (uwp|emscripten|android|arm)?
- [x] Fix library names on !x64 (currently hardcoded to x64 or x86;
failure in aricpp since it forces FindBoost module mode.)
- [x] ~~Fix arm64-windows boost-context builds -> requires CMake
(3.19.2?) update due to bug how the assembler is invoked.~~ (-> CI
baseline for now)

TODO:
- [x] adjust generate ports script
- [x] #37457

---------

Co-authored-by: Cheney-Wang <[email protected]>
yurybura pushed a commit to yurybura/vcpkg that referenced this issue May 8, 2024
~~arm64-windows: boost-context builds are blocked by a cmake bug (see
https://gitlab.kitware.com/cmake/cmake/-/issues/24317)~~

closes microsoft#32274
closes Neumann-A/my-vcpkg-triplets#5

Questions:
- [x] ~~Move cmake files to `share/cmake/<name>` ?~~ Not doing it
because it is just using `vcpkg_cmake_config_fixup()`
- [x] Fix weak dependencies (uwp|emscripten|android|arm)?
- [x] Fix library names on !x64 (currently hardcoded to x64 or x86;
failure in aricpp since it forces FindBoost module mode.)
- [x] ~~Fix arm64-windows boost-context builds -> requires CMake
(3.19.2?) update due to bug how the assembler is invoked.~~ (-> CI
baseline for now)

TODO:
- [x] adjust generate ports script
- [x] microsoft#37457

---------

Co-authored-by: Cheney-Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants