Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap compilation failure on RPi OS #21142

Closed
mprather opened this issue Nov 2, 2021 · 3 comments
Closed

bootstrap compilation failure on RPi OS #21142

mprather opened this issue Nov 2, 2021 · 3 comments
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@mprather
Copy link

mprather commented Nov 2, 2021

Describe the bug
As of 5bdb9d6, the bootstrap compilation process fails on RPi OS.

Environment

To Reproduce
Steps to reproduce the behavior:

  1. clone vcpkg
  2. run ./bootstrap-vcpkg.sh

Result:
the bootstrap is unable to complete compilation due to failure with messages.cpp

Expected behavior
bootstrap should complete successfully. It was working until commit 5bdb9d6 was introduced

Failure logs
[31/122] Building CXX object CMakeFiles/vcpkglib.dir/src/vcpkg/base/messages.cpp.o
FAILED: CMakeFiles/vcpkglib.dir/src/vcpkg/base/messages.cpp.o
/usr/bin/c++ -DFMT_LOCALE -DVCPKG_BASE_VERSION=2021-10-25 -DVCPKG_VERSION=unknownhash -I/home/c/src/vcpkg/buildtrees/_vcpkg/src/vcpkg-tool-2021-10-25/include -I_deps/fmt-src/include -O3 -DNDEBUG -include /home/c/src/vcpkg/buildtrees/_vcpkg/src/vcpkg-tool-2021-10-25/include/pch.h -pthread -std=c++17 -MD -MT CMakeFiles/vcpkglib.dir/src/vcpkg/base/messages.cpp.o -MF CMakeFiles/vcpkglib.dir/src/vcpkg/base/messages.cpp.o.d -o CMakeFiles/vcpkglib.dir/src/vcpkg/base/messages.cpp.o -c /home/c/src/vcpkg/buildtrees/_vcpkg/src/vcpkg-tool-2021-10-25/src/vcpkg/base/messages.cpp
/usr/include/c++/8/ext/new_allocator.h:136:4: error: call of overloaded ‘StringView(vcpkg::StringLiteral&)’ is ambiguous
{ ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }

Additional context

@PhoebeHui PhoebeHui added requires:more-information This Issue requires more information to solve category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) and removed requires:more-information This Issue requires more information to solve labels Nov 3, 2021
@PhoebeHui
Copy link
Contributor

@BillyONeal, could you please take a look? I looks a vcpkg bug, however, I don't have that environment to double confirm this issue locally.

@BillyONeal
Copy link
Member

Yeah now that we are doing binary releases on all the main platforms building from source is going to get progressively more annoying.... which is half the point of wanting to do those binary releases (so that we can use real dependencies).

BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this issue Mar 23, 2022
BillyONeal pushed a commit to microsoft/vcpkg-tool that referenced this issue Mar 25, 2022
* Added template constructor to StringView

Compilation on Raspberry Pi OS with gcc 8.3 was failing because the
StringView class did not have constructor defined for ZStringView.

Addresses microsoft/vcpkg#21142

* Added atomic library to link list

Addresses microsoft/vcpkg#22843
Related to microsoft/vcpkg#21142

* Added expression filter for atomic

* Corrected filter expression

* Detect libatomic

* fix it the strega way!

* Adjust atomic test code

* strega nits

Co-authored-by: Robert Schumacher <[email protected]>
Co-authored-by: nicole mazzuca <[email protected]>
Co-authored-by: nicole mazzuca <[email protected]>
BillyONeal added a commit to microsoft/vcpkg-tool that referenced this issue Mar 29, 2022
* Delete implicit conversion from StringLiteral to std::string.

Attempted resolution of microsoft/vcpkg#21142

* Avoid addition of .to_string() in JSON consumers

* Fix build failures.

* CR nitpicks:

* Reorder the && overloads before their calling templates.
* Use const T& rather than && where possible.
* Use enable_if_t consistently.
* Change messages.h to be consistent with the json.h examples.

Co-authored-by: Robert Schumacher <[email protected]>
@mprather
Copy link
Author

This has been addressed with the tool update on 3/28/22, commit 671db8a. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

No branches or pull requests

3 participants