Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line parser prerequisites #853

Merged
merged 13 commits into from
Jan 13, 2023
Merged

Command line parser prerequisites #853

merged 13 commits into from
Jan 13, 2023

Conversation

BillyONeal
Copy link
Member

I'm overhauling the command line parser to fix the longstanding "space vs =" bug soon. These are a couple mechanical changes to do ahead of that to make reviewing that easier:

  • Change all filenames to have -s rather than _s.
  • Extract HelpTableFormatter from VcpkgCmdArguments, and add a smoke test.
  • Introduce IReadLines as an extraction of Filesystem, and ExpectedL-ize.

@BillyONeal BillyONeal changed the title Command line parser rerequisites Command line parser prerequisites Jan 11, 2023
@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

vicroms
vicroms approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits but LGTM

@BillyONeal BillyONeal merged commit 17bb1b8 into microsoft:main Jan 13, 2023
@BillyONeal BillyONeal deleted the cmd-parser-prereq-1 branch January 13, 2023 02:54
@autoantwort
Copy link
Contributor

I think this broke the ci format check because now the diff is executed before the generate-message-map target runs and you get a green ci without updating messages.json. Happened in #894

@autoantwort autoantwort mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyONeal @autoantwort @vicroms