Mark functions as static and const #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
final
branch
6 times, most recently
from
8d79a52 to
e6fc63d
Compare
BillyONeal
requested changes
Oct 26, 2022
include/vcpkg/base/format.h
Outdated
| @@ -25,7 +25,7 @@ namespace fmt | |||
| template<> | |||
| struct formatter<vcpkg::LineInfo, char> | |||
| { | |||
| constexpr auto parse(format_parse_context& ctx) const -> decltype(ctx.begin()) | |||
| static constexpr auto parse(format_parse_context& ctx) -> decltype(ctx.begin()) | |||
There was a problem hiding this comment.
As I indicated in the other PR, this is following the formatter protocol, so this change damages correctness. https://fmt.dev/latest/api.html#formatting-user-defined-types
(fmt wants to call with a.b syntax not a::b syntax)
Adding const would be OK.
src/vcpkg-test/expected.cpp
Outdated
| @@ -76,7 +76,8 @@ namespace | |||
| ++cr->move_assigns; | |||
| return *this; | |||
| } | |||
| std::string to_string() const { return "a construct tracker"; } | |||
|
|
|||
| static std::string to_string() { return "a construct tracker"; } | |||
There was a problem hiding this comment.
This is no longer following the obj.to_string() protocol.
|
@BillyONeal Done! |
Also use constexpr where we can
BillyONeal
approved these changes
Oct 28, 2022
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.