Make pushing back to vectors more efficient #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
fix-3
branch
2 times, most recently
from
0cd17b7 to
caad698
Compare
AZero13
changed the title
|
Hi @AtariDreams, thank you for the contributions. How did you determine what to refactor? Are you using a tool we could potentially use for our tests? |
BillyONeal
requested changes
Oct 26, 2022
clang-tidy checks for modernize-use-emplace. |
|
@BillyONeal fixed! |
BillyONeal
requested changes
Oct 28, 2022
AZero13
force-pushed
the
fix-3
branch
2 times, most recently
from
525ede1 to
106f267
Compare
|
@BillyONeal Done! |
AZero13
force-pushed
the
fix-3
branch
4 times, most recently
from
a320310 to
978986d
Compare
|
Any update on this? |
In these places, emplace_back seems to be more efficient than push_back, and the better choice.
It saves a lot of work reserving and working with references instead of copying directly
Co-authored-by: Billy O'Neal <[email protected]>
BillyONeal
approved these changes
Nov 3, 2022
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these places, emplace_back seems to be more efficient than push_back, and the better choice.
We can also improve performance further by reserving the size we know the vector will be so we do not have to waste time resizing.