Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE.txt to the one-liner. #715

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

BillyONeal
Copy link
Member

Olga discovered that vcpkg-cmake expects a LICENSE.txt in VCPKG_ROOT. This includes that in the standalone bundle.

See https://github.com/microsoft/vcpkg/blob/57d3194e702a2959e86a6748999ad71fc24f7922/ports/vcpkg-cmake/portfile.cmake#L13

Olga discovered that vcpkg-cmake expects a LICENSE.txt in `VCPKG_ROOT`. This includes that in the standalone bundle.

See https://github.com/microsoft/vcpkg/blob/57d3194e702a2959e86a6748999ad71fc24f7922/ports/vcpkg-cmake/portfile.cmake#L13
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should seek to fix this in the future by either making vcpkg-cmake have its own included license file or maybe have a dedicated vcpkg-license port that other helpers can depend upon to avoid copy-pasting the license into every helper port..

@BillyONeal
Copy link
Member Author

LGTM, but we should seek to fix this in the future by either making vcpkg-cmake have its own included license file or maybe have a dedicated vcpkg-license port that other helpers can depend upon to avoid copy-pasting the license into every helper port..

At this point the license is contractual so not sure if there's much benefit in avoiding it.

@BillyONeal BillyONeal merged commit da270f4 into microsoft:main Sep 27, 2022
@BillyONeal BillyONeal deleted the include-license-in-one-liner branch September 27, 2022 17:09
@dg0yt
Copy link
Contributor

dg0yt commented Sep 28, 2022

we should seek to fix this in the future by either making vcpkg-cmake have its own included license file or maybe have a dedicated vcpkg-license port that other helpers can depend upon to avoid copy-pasting the license into every helper port..

The idea is that the helper ports are part of vcpkg and use exactly the same license, implemented by using exactly the same file.

@ras0219-msft
Copy link
Contributor

While the deduplication gained by relying on the vcpkg root copy is nice, it adds an unexpected contract (the license must forevermore be deployed with $NAME under $VCPKG_ROOT).

Though as BillyONeal said above, that ship has already sailed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants