Detect whether vcpkg is running in a CI environment #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
approved these changes
Sep 23, 2022
# Conflicts: # src/vcpkg/metrics.cpp
BillyONeal
approved these changes
Sep 26, 2022
BillyONeal
approved these changes
Sep 26, 2022
Thomas1664
reviewed
Sep 26, 2022
|
When vcpkg detects CI environments, can we customize the output to mark error messages, e.g. for AZP? |
That is a great suggestion! By all means do! |
vicroms
changed the title
vicroms
force-pushed
the
telemetry-ci-providers
branch
3 times, most recently
from
bdf5dfc to
e1675b7
Compare
vicroms
force-pushed
the
telemetry-ci-providers
branch
from
e1675b7 to
852cf72
Compare
BillyONeal
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
I really don't think this test is meaningful because the product bug that's going to happen is a misunderstanding of how those variables are set, and this isn't going to find that.
However, I don't believe it is actively harmful as long as these tests don't take too long to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use well known environment variables to detect whether we are running in a CI environment.
VCPKG_NO_CIenvironment variable vcpkg#27000