Improve prefilled issue template #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
approved these changes
Sep 3, 2022
| LocalizedString create_user_troubleshooting_message(const InstallPlanAction& action, | ||
| const VcpkgPaths& paths, | ||
| Optional<Path>&& issue_body = nullopt); | ||
| LocalizedString create_user_troubleshooting_message(const InstallPlanAction& action, const VcpkgPaths& paths); |
There was a problem hiding this comment.
Since it's now an error to call this IMO it would be better to just inline it (and put the definition of print_user_troubleshooting_message into build.cpp?)
There was a problem hiding this comment.
This is not possible:
vcpkg-tool\src\vcpkg\install.cpp(525,17): error C3861: "print_user_troubleshooting_message": identifier not found
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color::warningto better distinguish it from the rest of the error message.after the path prevents users from navigating to the issue template directly from within the terminal.