Promote "info" fields out in artifacts for consistency with manifests. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that 'id' is not renamed to name because they can contain /s, and names cannot. Functional changes: * Hoist the info fields to MetadataFile. Add functionality to warn on regenerate-index if the 'info' block is present, optionally doing the conversion on the user's behalf. * Fixed x-regenerate not correctly calling ce when --debug et al. were specified because ce's console parser assumes ALL --foo bar says that bar is the value of foo. Code / refactoring-like changes: * Rename ValidationError to ValidationMessage since it may also be used for things that aren't errors now. * Delete the IInfo interface. * Removed "validationErrors" hanging off of MetadataFile. This was broken because it cached the result which may not hold after modifications. Exposed a function to format ValidationMessages from MetadataFile by extracting what used to be in that code though. * Rename Flags to Options since that's the name actually used. * Fixed some tests that were still passing yaml.
|
Resolves https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1495059 "the info block still exists" |
fearthecowboy
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that 'id' is not renamed to name because they can contain /s, and names cannot.
Functional changes:
Code / refactoring-like changes: