Localize commands3 #642
Merged
Localize commands3 #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FailedToReadParagraph MissingArgFormatManifest FailedToRemoveControl FailedToWriteManifest
FailedToReadParagraph FailedToParseControl FailedToWriteManifest FailedToRemoveControl
ErrorsFound SuggestResolution
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json
Thomas1664
reviewed
Jul 20, 2022
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/messages.cpp
ras0219-msft
reviewed
Aug 5, 2022
There was a problem hiding this comment.
This PR adds a lot of command-specific messages to the generic I see that this is now intended due to #615. Please disregard this review.messages.h header. I recommend going through each of them and consider moving each one that's only used once into the respective .cpp.
# Conflicts: # locales/messages.en.json # locales/messages.json
* Change the use of FailedToObtainLocalPortGitSha, FailedToWriteManifest, FailedToRemoveControl, FailedToFormatMissingFile to print the error prefix. * Add missing : in FailedToParseJson. * Delete now-unused JsonErrorFailedToParse and JsonErrorFailedToRead. * Words nitpick on MissingArgFormatManifest (was preexisting). * Change ControlAndManifestFilesPresent to check and add the error prefix rather than using a check form.
BillyONeal
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR localizes messages in the following files:
I also added the function append_nl() which simply appends a newline character to the localized message. Previously, newline characters were added by using append_raw("\n").