Implement 'new' in C++. #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most callers were just default-initializing JsonStyle which is equivalent to the WithSpaces(2) form. WithSpaces(2) and default-initialized changed to call the new overload(s). Callers who were stringifying 2 Json entities just to compare their strings also dropped the style parameter. Callers who were using anything else were left alone.
This replaces the TypeScript implementation of new with a C++ one. Other changes: * Now creates both vcpkg.json and vcpkg-configuration.json, which resolves "vcpkg new does not create vcpkg.json" https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1494967 * vcpkg-configuration.json can be embedded into vcpkg.json with --single-file. * Now fills in the default registry with the current baseline git SHA. * --name and --version are now mandatory since we are creating vcpkg.json, but they can be skipped with --application as per microsoft#605
JavierMatosD
reviewed
Jul 7, 2022
| bool option_version_relaxed, | ||
| bool option_version_date, | ||
| bool option_version_string) | ||
| { |
There was a problem hiding this comment.
This is just personal preference, but the function could be easier to digest if it were split into smaller chunks for each option and just pass the manifest as an argument.
There was a problem hiding this comment.
I'm not sure I understand: the manifest is the return value? Can you show the declarations you'd be looking for?
JavierMatosD
approved these changes
Jul 7, 2022
# Conflicts: # src/vcpkg/commands.add.cpp
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.en.json
vicroms
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the TypeScript implementation of new with a C++ one. Other changes: