Fix artifact search to work well with multiple versions of artifacts and registries #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Jun 29, 2022
|
VS
|
# Conflicts: # ce/ce/installers/git.ts
BillyONeal
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching artifacts on a specific registry didn't work quite right.
This makes it so if the user prefixes the search criteria with a registry ie
vcpkg find artifact arm:gccthat it will just search the given registry.It also prints a message when there are no search results at all.
And when it uses the current internal ce downloader, puts the version and hash in the filename because otherwise it would clobber the download file when it switches between versions.