Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small optimizations #572

Merged
merged 10 commits into from
Jun 8, 2022
Merged

Small optimizations #572

merged 10 commits into from
Jun 8, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Jun 4, 2022 •
edited
Loading

  • unordered_map instead of map
  • Avoid copy during loop

BillyONeal
BillyONeal reviewed Jun 4, 2022
View reviewed changes
@Thomas1664 Thomas1664 marked this pull request as ready for review June 4, 2022 15:51
@Thomas1664 Thomas1664 changed the title Use StringView::substr() Small optimizations Jun 4, 2022
@Thomas1664 Thomas1664 marked this pull request as draft June 4, 2022 15:58
@Thomas1664 Thomas1664 marked this pull request as ready for review June 4, 2022 18:31
@BillyONeal BillyONeal merged commit 2f25d2c into microsoft:main Jun 8, 2022
@BillyONeal
Copy link
Member

Thanks!

@Thomas1664 Thomas1664 deleted the replace-substr branch June 8, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas1664 @BillyONeal