[AWS] Stat file before downloading it when doing binary cache lookup. #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when downloading file while doing binary caching lookup fails with an error because there is a cache miss, msbuild interprets this as an error and fails the build step. Also, this adds a fatal error message in the log that is usually not ok because cache miss is a normal and expected situation. This PR adds a stat operation before actual file download on cache lookup to eliminate fatal error and prettify log a little. Signed-off-by: Vitalii Koshura <[email protected]>
|
@BillyONeal, please review |
|
@dave-juicelabs @mathisloge Tagging you since you were involved in #293 . Are you interested in review? This looks fine as far as vcpkg is concerned but all the impacts here seem to be related to AWS specifics with which I have no experience. |
dave-juicelabs
approved these changes
May 31, 2022
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when downloading file while doing binary caching lookup fails with an error because there is a cache miss, msbuild interprets this as an error and fails the build step. Also, this adds a fatal error message in the log that is usually not ok because cache miss is a normal and expected situation.
This PR adds a stat operation before actual file download on cache lookup to eliminate fatal error and prettify log a little.
Signed-off-by: Vitalii Koshura [email protected]