Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract IGit #556

Closed
wants to merge 28 commits into from
Closed

Extract IGit #556

wants to merge 28 commits into from

Conversation

ras0219-msft
Copy link
Contributor

Picking up #529 since @vicroms does not have time to push it through.

This PR condenses all use of git to go through a narrow IGit interface. This hides the underlying implementation, potentially for future replacement by libgit2.

@BillyONeal
Copy link
Member

potentially for future replacement by libgit2

Considering that doesn't seem to be maintained anymore I highly doubt we would do that

@ras0219-msft
Copy link
Contributor Author

https://github.com/libgit2/libgit2 shows the last commit at 22 days ago.

libgit2 is used to power Git GUI clients like GitKraken and gmaster and on Git hosting providers like GitHub, GitLab and Azure DevOps. We perform the merge every time you click "merge pull request".

@BillyONeal
Copy link
Member

It's been over 3 months, @ras0219-msft are you still working on this or should it be closed for now?

vicroms
vicroms reviewed Sep 29, 2022
View reviewed changes
src/vcpkg/registries.cpp
const auto& git = paths.get_git_impl(stdout_sink);
GitLsTreeOptions opts = {};
opts.dirs_only = true;
auto maybe_files = git.ls_tree(paths.git_builtin_config(), "HEAD:ports/", opts);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End-to-end tests are failing due to this hardcoded "HEAD:ports/". We should make this use the value of --x-builtin-ports-root.

@vicroms vicroms mentioned this pull request Oct 9, 2022
Merged
@BillyONeal
Copy link
Member

As this has had no work in over 6 months, I'm closing it for now. Please feel to reopen or make a new PR should you choose to pick it back up again :)

@BillyONeal BillyONeal closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ras0219-msft @BillyONeal @vicroms