Suppress fmt warning with new MSVC #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should take this version of the fix instead: https://github.com/microsoft/vcpkg-tool/pull/522/files#diff-91ac5be63fa35d15f15d52ef285a82eb137c5c3a89cafd6dba8302af3c7f569a since it (1) separates out what is just fmt and warning suppressions from the rest of our additional stuff, and (2) contains a comment describing why we are suppressing that particular number. Do you want me to factor that change into a separate review? (Since that PR looks like it will due to merge hell) |
|
I'll migrate that change into this PR and ping you afterwards. Thanks for the pointer! |
ras0219-msft
force-pushed
the
dev/roschuma/fmt-suppress
branch
from
19142ea to
c8e3f66
Compare
BillyONeal
approved these changes
May 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.