Fix end to end tests on VS2022 only systems. #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BillyONeal
commented
Apr 22, 2022
BillyONeal
commented
- Change PlatformToolset to v143.
- Make e2e tests figure out the right Triplet to use on their own (previously, the vs-integration tests only passed given x86-windows so we may as well just lock it to that)
- Provide a default WorkingRoot in a reasonable place.
- Add CMake entries to the vcpkgTools.xml used in testing so that the tests pass if CMake is needed to extract a zip.
* Change PlatformToolset to v143. * Make e2e tests figure out the right Triplet to use on their own (previously, the vs-integration tests only passed given x86-windows so we may as well just lock it to that) * Provide a default WorkingRoot in a reasonable place. * Add CMake entries to the vcpkgTools.xml used in testing so that the tests pass if CMake is needed to extract a zip.
ras0219-msft
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.