Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build result type for removed. #500

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

BillyONeal
Copy link
Member

Resolves microsoft/vcpkg#24029

Before (2022-03-30):
before

Currently: (vcpkg crashes, regression in 8e8fb17 )

After:
after

@BillyONeal
Copy link
Member Author

As an aside, while we are here should we strip 0 line items from the summary?

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and removing 0 entries seems reasonable as well.

@BillyONeal
Copy link
Member Author

LGTM, and removing 0 entries seems reasonable as well.

Done, now looks like:

image

@BillyONeal BillyONeal merged commit a7eff45 into microsoft:main Apr 11, 2022
@BillyONeal BillyONeal deleted the upgrade-value-was-null-as-well branch April 11, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg upgrade] Displays Value was null instead of how many ports installed, failed, cascaded, etc
3 participants