Start removing std::regex #427

strega-nil · 2022-03-10T00:56:42Z

No description provided.

include/vcpkg/base/util.h

include/vcpkg/postbuildlint.buildtype.h

src/vcpkg-test/util-tests.cpp

src/vcpkg/archives.cpp

BillyONeal · 2022-03-11T21:35:00Z

src/vcpkg/binarycaching.cpp

+        // 0 1 2 3 4 5 6 7 8 9 10
+        if (version.size() < 10) return false;
+        auto first = version.begin();
+        if (!P::is_ascii_digit(*first++)) return false;


Note to self/others: it would be really nice to not have yet another parser for this vs the one in DateVersion. No change requested.

BillyONeal · 2022-03-11T21:36:28Z

include/vcpkg/binarycaching.private.h

+    // - v?<X>.<Y><whatever> -> <X>.<Y>.0-vcpkg<abitag>
+    // - v?<X>.<Y>.<Z><whatever> -> <X>.<Y>.<Z>-vcpkg<abitag>
+    // - anything else -> 0.0.0-vcpkg<abitag>
+    std::string reformat_version(StringView version, StringView abi_tag);


Suggested change

std::string reformat_version(StringView version, StringView abi_tag);

std::string add_abitag_version_suffix(StringView version, StringView abi_tag);

BillyONeal

Since it doesn't look like vcpkg::reformat_version is exercised unless a nuget binary or asset cache is used, I would like to see some unit tests added for that (and renamed as commented before). Other than that LGTM!

strega-nil-ms · 2022-03-11T22:27:05Z

@BillyONeal there are unit tests for it already (hence why I'm confident that the new code is equivalent to the old code :P)

BillyONeal · 2022-03-11T22:42:51Z

@BillyONeal there are unit tests for it already (hence why I'm confident that the new code is equivalent to the old code :P)

"cool beans"

strega-nil added 4 commits March 9, 2022 15:39

[remove-regex] remove from postbuildlint.buildtype

e2e4523

remove regex from archives.cpp

a79aae9

[remove-regex] postbuildlint.cpp

d14d903

[remove-regex] vcpkglib.cpp

b336507

strega-nil changed the title ~~Remove std::regex~~ Start removing std::regex Mar 10, 2022