Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable disabled warnings which are no longer relevant #411

Merged
merged 4 commits into from
Mar 3, 2022
Merged

re-enable disabled warnings which are no longer relevant #411

merged 4 commits into from
Mar 3, 2022

Conversation

strega-nil
Copy link
Contributor

try to find all the warnings that are still an issue in modern VS

Also, standardize on VCPKG_MSVC_WARNING

@strega-nil
remove all pragma warnings
f6fafd7 
try to find all the warnings that are still an issue
@strega-nil
add suppress 6335 in system.process.cpp
0b10a5d
@strega-nil-ms strega-nil-ms force-pushed the remove-other-disables branch from 015541b to 0b10a5d Compare March 3, 2022 21:38
BillyONeal
BillyONeal approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see the commit title when merged to be something like:

pragma warning => VCPKG_MSVC_WARNING

to indicate that we aren't just blindly removing stuff.

@strega-nil strega-nil changed the title remove all pragma warnings re-enable disabled warnings which are no longer relevant Mar 3, 2022
@BillyONeal BillyONeal merged commit b1193bf into microsoft:main Mar 3, 2022
@strega-nil strega-nil deleted the remove-other-disables branch March 4, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strega-nil @BillyONeal