-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files::get_regular_files_recursive_proximate #337
Merged
BillyONeal
merged 4 commits into
microsoft:main
from
ras0219-msft:dev/roschuma/proximate
Jan 31, 2022
Merged
Files::get_regular_files_recursive_proximate #337
BillyONeal
merged 4 commits into
microsoft:main
from
ras0219-msft:dev/roschuma/proximate
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1a8985
to
603f970
Compare
603f970
to
62e9b4b
Compare
BillyONeal
reviewed
Jan 27, 2022
BillyONeal
reviewed
Jan 27, 2022
BillyONeal
reviewed
Jan 27, 2022
BillyONeal
reviewed
Jan 27, 2022
BillyONeal
reviewed
Jan 27, 2022
BillyONeal
requested changes
Jan 27, 2022
d43bef4
to
942ea14
Compare
BillyONeal
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Files::get_regular_files_recursive_proximate
, which returns a list of all regular files from a subdirectory without that base path prepended. The result is the same as if you calledHowever it generates the desired contents directly instead of "subtracting" after the fact on Linux.
This is needed for #296