Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files::get_regular_files_recursive_proximate #337

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Jan 27, 2022

This PR implements Files::get_regular_files_recursive_proximate, which returns a list of all regular files from a subdirectory without that base path prepended. The result is the same as if you called

// pseudocode
files = Files::get_regular_files_recursive(dir);
for (auto& file : files) {
    file = file.lexically_proximate(dir);
}

However it generates the desired contents directly instead of "subtracting" after the fact on Linux.

This is needed for #296

@ras0219-msft ras0219-msft force-pushed the dev/roschuma/proximate branch from a1a8985 to 603f970 Compare January 27, 2022 22:36
@ras0219-msft ras0219-msft force-pushed the dev/roschuma/proximate branch from d43bef4 to 942ea14 Compare January 28, 2022 18:49
@ras0219-msft ras0219-msft marked this pull request as ready for review January 28, 2022 20:49
@BillyONeal BillyONeal merged commit f82ce3f into microsoft:main Jan 31, 2022
@ras0219-msft ras0219-msft deleted the dev/roschuma/proximate branch January 31, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants