Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[host_triplet] fix check for arm64 under x64 binary #333

Merged
merged 3 commits into from
Jan 25, 2022
Merged

[host_triplet] fix check for arm64 under x64 binary #333

merged 3 commits into from
Jan 25, 2022

Conversation

strega-nil
Copy link
Contributor

BillyONeal
BillyONeal reviewed Jan 24, 2022
View reviewed changes
src/vcpkg/base/system.cpp Outdated
auto raw_identifier = get_environment_variable("PROCESSOR_IDENTIFIER");
if (const auto id = raw_identifier.get())
{
if (Strings::contains(id, "ARMv") && Strings::contains(id, "(64 bit)"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Strings::contains(id, "ARMv") && Strings::contains(id, "(64 bit)"))
if (Strings::contains(id, StringLiteral{"ARMv"}) && Strings::contains(id, StringLiteral{"(64 bit)"}))

will fix your build failure

@strega-nil-ms strega-nil-ms merged commit 928d211 into microsoft:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strega-nil @BillyONeal @ras0219-msft @strega-nil-ms