Fix CI crash due to missing package ABIs #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR microsoft#298 introduced a regression during ABI calculation for packages that do not have features. It removed the implicit entry "core" from InstallPlanAction::feature_list, which meant that packages without features would end up with an empty ABI tag for their features list. We consider an empty ABI tag in the features list to indicate that a value could not be calculated and therefore that the package cannot be cached (no ABI). This then resulted in a crash during CI which assumes that all packages have ABIs.
BillyONeal
reviewed
Jan 24, 2022
|
|
||
| for (size_t i = 0; i < actions.size(); ++i) | ||
| { | ||
| if (cache_status[i] == nullptr) |
There was a problem hiding this comment.
Rather than here, I think this should be added to https://github.com/microsoft/vcpkg-tool/pull/331/files#diff-045a3245d6bccf63618bd35376d0a973af7805c6e232bbbf222ca326b60b7000L1422
Ever asking the binary cache about a package without an ABI hash is a bug and should blow up.
|
I tried adding an assert that vcpkg-tool/src/vcpkg/packagespec.cpp Line 58 in e49443d Robert and I discussed this offline and he agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #298 introduced a regression during ABI calculation for packages
that do not have features. It removed the implicit entry "core"
from
InstallPlanAction::feature_list, which meant that packageswithout features would end up with an empty ABI tag for their
features list.
We consider an empty ABI tag to indicate that
a value could not be calculated and therefore that the package
cannot be cached (no ABI). This then resulted in a crash during CI
which assumes that all packages have ABIs.