Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto create issue on install failure #311

Merged
merged 23 commits into from
Jun 2, 2022

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort changed the title WIP: Auto create issue on install failure Auto create issue on install failure Dec 26, 2021
@autoantwort
Copy link
Contributor Author

autoantwort commented Dec 26, 2021

For example, this created microsoft/vcpkg#22206 and microsoft/vcpkg#22207

Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! I want @ras0219-msft to take a look first (so it probably won't get merged until january), but I'm definitely a 👍.

Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't assume linux, since someone might be running this on z/OS for example.

@strega-nil-ms strega-nil-ms added the requires:discussion This PR requires discussion of the correct way forward label Jan 11, 2022
@strega-nil-ms strega-nil-ms removed the requires:discussion This PR requires discussion of the correct way forward label Jan 20, 2022
@autoantwort
Copy link
Contributor Author

Can be merged now :)

# Conflicts:
#	include/vcpkg/build.h
#	src/vcpkg/build.cpp
#	src/vcpkg/install.cpp
@BillyONeal BillyONeal merged commit ff840a0 into microsoft:main Jun 2, 2022
@autoantwort autoantwort deleted the auto-create-issue branch August 9, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants