implement vcpkg add port #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
reviewed
Dec 15, 2021
strega-nil
reviewed
Dec 15, 2021
strega-nil
reviewed
Dec 15, 2021
strega-nil
reviewed
Dec 15, 2021
strega-nil
suggested changes
Dec 15, 2021
strega-nil
approved these changes
Dec 16, 2021
|
LGTM! I just want @ras0219-msft to take a look first, so we'll finish taking a look in the new year. |
strega-nil-ms
added
the
requires:discussion
strega-nil-ms
approved these changes
Dec 29, 2021
strega-nil-ms
force-pushed
the
implement-vcpkg-add-port
branch
from
660938a to
773792e
Compare
BillyONeal
approved these changes
Jan 6, 2022
ras0219-msft
approved these changes
Jan 6, 2022
Co-authored-by: Robert Schumacher <[email protected]>
strega-nil-ms
added
requires:author-response
and removed
requires:discussion
|
Thank you so much for this new feature! :D |
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 5, 2022
microsoft#301 broke add artifact by flipping the sense of check_exit: it is "ensure that this is true" not "fail when this is true". Drivebys: `add port` was also broken because it would try to add a port named "port". 60: Fix the flipped sense. 78: Replace fmap with a for loop starting at 1 to skip the selector. 80: Use Expected::value_or_exit which was equivalent to the previous behavior of printing the message followed by exit_fail. 84: Similarly combine printing msgAddTripletExpressionNotAllowed and exit_failure into msg_exit_with_message. 126: Similarly, write_contents' default behavior of exiting and printing the path in question with VCPKG_LINE_INFO was equivalent to checking error_code
BillyONeal
added a commit
that referenced
this pull request
Mar 7, 2022
…#415) * Fix add artifact regression "you can only add one artifact at a time" #301 broke add artifact by flipping the sense of check_exit: it is "ensure that this is true" not "fail when this is true". Drivebys: `add port` was also broken because it would try to add a port named "port". 60: Fix the flipped sense. 78: Replace fmap with a for loop starting at 1 to skip the selector. 80: Use Expected::value_or_exit which was equivalent to the previous behavior of printing the message followed by exit_fail. 84: Similarly combine printing msgAddTripletExpressionNotAllowed and exit_failure into msg_exit_with_message. 126: Similarly, write_contents' default behavior of exiting and printing the path in question with VCPKG_LINE_INFO was equivalent to checking error_code * Regenerate localization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.