Add 'embeddedsha' to record tested baseline for bundle #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
force-pushed
the
dev/roschuma/readonly
branch
from
d523768 to
bc5a396
Compare
|
One main aspect of #197 was to get the date of the used vcpkg version for issues. You now always see in the issues how old the vcpkg version is they used to build a port (for example This feature gets removed with this PR |
|
I see, I assumed it was primarily about the commit id. Let me see about adding date information. |
BillyONeal
approved these changes
Nov 17, 2021
ras0219-msft
force-pushed
the
dev/roschuma/readonly
branch
from
2ca7cb5 to
16c9987
Compare
|
I've restored the date display behavior for existing cases, however the read-only bundle probably needs a different treatment (the date information needs to come from somewhere else). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change in this PR is very small: Add
$bundle.embeddedshato enable read-only vcpkg to provide useful error messages around baselines.While investigating the general problem, I discovered several other functions that were generally 'unsafe' (they depend upon
root / ".git"), but in the single context they're used are safe. I therefore refactored things to move those functions closer to their contexts and out of the publicVcpkgPaths::interface.