Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support media queries binary logical operator syntax in platform expressions #267

Merged
merged 12 commits into from
Nov 17, 2021
Merged

Support media queries binary logical operator syntax in platform expressions #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
323e039
add initial support for media query syntax - 'and' and ','
markle11m Nov 11, 2021
e5f3ce7
add support to treating ',' as having lower precedence than '&' or 'and'
markle11m Nov 11, 2021
a60eb91
add test cases, remove TODOs
markle11m Nov 11, 2021
36a63c2
fix PR diff formatting issue
markle11m Nov 12, 2021
24ec1d1
feedback: add minimum whitespace test case
markle11m Nov 16, 2021
df6ef3b
feedback: name cannot be empty() at that point in the code; removing …
markle11m Nov 16, 2021
04e971d
additional test cases for valid 'not' expressions and invalid 'and'/'…
markle11m Nov 16, 2021
29940f0
handle 'or' - emit error directing use of '|' instead
markle11m Nov 16, 2021
9d3d0bc
test case for operator keywords embedded in identifiers
markle11m Nov 16, 2021
80cb231
add test cases for lack of whitespace around 'and'/'not' keyword oper…
markle11m Nov 16, 2021
617cc57
update comments to match proposed EBNF documentation
markle11m Nov 17, 2021
f5cce9d
review feedback: update comment to match EBNF
markle11m Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading