Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently construct paths using host's separator #250

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Consistently construct paths using host's separator #250

merged 2 commits into from
Nov 4, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 4, 2021

To fix ugly mixed separator output in error messages on windows, e.g.

-- Performing post-build validation
Import libs were not present in F:\vcpkg\packages\lapack-reference_x64-windows\debug/lib

(from microsoft/vcpkg#21060)

@ras0219-msft ras0219-msft merged commit 1d3d3ea into microsoft:main Nov 4, 2021
@ras0219-msft
Copy link
Contributor

This looks like a strict improvement to me, thanks for the PR!

@dg0yt dg0yt deleted the path-separator branch November 4, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg0yt @ras0219-msft