Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'x-script' asset caching protocol #237

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

ras0219-msft
Copy link
Contributor

No description provided.

@ras0219-msft
Copy link
Contributor Author

/azp run

@ras0219-msft ras0219-msft marked this pull request as ready for review November 14, 2021 23:55
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft ras0219-msft force-pushed the dev/roschuma/terrapin-2 branch from a99b24f to 4b19197 Compare November 19, 2021 18:29
Comment on lines +2115 to +2117
tbl.format("x-script,<template>",
"Dispatches to an external tool to fetch the asset. Within the template, \"{url}\" will be replaced by "
"the original url, \"{sha512}\" will be replaced by the SHA512 value, and \"{dst}\" will be replaced by "
"the output path to save to. These substitutions will all be properly shell escaped, so an example "
"template would be: \"curl -L {url} --output {dst}\". \"{{\" will be replaced by \"}\" and \"}}\" will "
"be replaced by \"}\" to avoid expansion. Note that this will be executed inside the build environment, "
"so the PATH and other environment variables will be modified by the triplet.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think fully describing the format is necessarily appropriate for help text. Can this be turned into a link to the docs instead?

I mention this because we're starting to have a problem with our help text being so long that it doesn't fit on a screen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think it may be good to do that for other entries too. This one is longer than those but they aren't great either)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a problem with the help text output from specifically vcpkg help <topic> being too verbose/lengthy; I see it like git foo -h versus git foo --help: -h displays short help (ideally one page, enough to remember key options), and --help displays much more verbose reference docs that extensively cover every option in a terse way.

@ras0219-msft ras0219-msft merged commit bc042dd into microsoft:main Nov 30, 2021
@ras0219-msft ras0219-msft deleted the dev/roschuma/terrapin-2 branch November 30, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants