Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[localization 1/n] First minor changes, mostly additive #218

Merged
merged 11 commits into from
Oct 26, 2021
Merged

[localization 1/n] First minor changes, mostly additive #218

merged 11 commits into from
Oct 26, 2021

Conversation

strega-nil
Copy link
Contributor

Additionally, convert vcpkg.cpp over to using messages.h

cc @ras0219

This was referenced Oct 14, 2021
Closed
Closed
@strega-nil-ms strega-nil-ms force-pushed the localization-1 branch 3 times, most recently from 82d6c5a to 1f34bef Compare October 14, 2021 22:00
strega-nil
strega-nil commented Oct 14, 2021
View reviewed changes
@strega-nil
Copy link
Contributor Author

strega-nil commented Oct 14, 2021 •
edited
Loading

Also - don't merge this until the legal stuff is handled (component governance, NOTICE file) done!

strega-nil-ms pushed a commit to strega-nil/vcpkg-tool that referenced this pull request Oct 15, 2021
@strega-nil
PR microsoft#218 [localization 1/n] First minor changes, mostly additive
57325cf 
Additionally, convert vcpkg.cpp over to using messages.h
BillyONeal
BillyONeal reviewed Oct 15, 2021
View reviewed changes
BillyONeal
BillyONeal approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit nit nit nit nit

Neumann-A
Neumann-A reviewed Oct 25, 2021
View reviewed changes
ras0219-msft
ras0219-msft approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to merge once CI passes.

@ras0219-msft ras0219-msft merged commit 5b939c9 into microsoft:main Oct 26, 2021
@strega-nil-ms strega-nil-ms deleted the localization-1 branch January 4, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms left review comments

@BillyONeal BillyONeal BillyONeal approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@strega-nil @BillyONeal @ras0219-msft @Neumann-A @strega-nil-ms