Add arm64 signed official builds. #209
Conversation
CMakeLists.txt
Outdated
| @@ -137,6 +138,9 @@ target_compile_definitions(vcpkglib PUBLIC | |||
| VCPKG_VERSION=${VCPKG_VERSION} | |||
| VCPKG_BASE_VERSION=${VCPKG_BASE_VERSION} | |||
| ) | |||
| if (WIN32) | |||
| target_compile_options(vcpkglib PRIVATE /EHsc) | |||
| endif() | |||
There was a problem hiding this comment.
Best to add /EHsc to CMAKE_CXX_FLAGS, I think, given that we're adding it to every C++ target; at some point before add_library, write string(APPEND CMAKE_CXX_FLAGS " /EHsc")
Do we have a use case? The original rationale for doing x86 only was that we don't do anything where perf matters and the x86 version runs on everything. ARM changed that; to my understanding the x86 on arm behavior is a lot less reasonable/transparent than the x86 on x64 behavior. I suppose technically the WOW64 subsystem can be uninstalled on servers but that's also likely to break most of our catalog so I'm not sure how much worrying about that is worth? |
No description provided.