Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report features and version on build error #200

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 27, 2021

When users report port build/install issues, it is often not obvious which features and package version they tried to install, even when they add command line output: versions and features are printed only early, for the "installation plan". This PR adds version and features to the final output statement, i.e. the instructions which information to include into an GH issue.

Tested with install and build command.

Example before this change:

$ ./vcpkg install qt5-base:x64-mingw-dynamic
Computing installation plan...
The following packages will be built and installed:
  * openssl[core]:x64-mingw-dynamic -> 1.1.1l#1
  * pcre2[core]:x64-mingw-dynamic -> 10.37
    qt5-base[core]:x64-mingw-dynamic -> 5.15.2#11
  * sqlite3[core]:x64-mingw-dynamic -> 3.36.0#1
  * zstd[core]:x64-mingw-dynamic -> 1.5.0
[... (too much to expect it to be posted in a typical GH issue) ...]
Error: Building package openssl:x64-mingw-dynamic failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: openssl:x64-mingw-dynamic
  Vcpkg version: 2021-09-10-unknownhash-debug

Additionally, attach any relevant sections from the log files above.

With this PR, the "Package" line in the final output changes to:

[...]
Error: Building package openssl:x64-mingw-dynamic failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: openssl[core]:x64-mingw-dynamic -> 1.1.1l#1
  Vcpkg version: 2021-09-10-unknownhash-debug

Additionally, attach any relevant sections from the log files above.

@BillyONeal BillyONeal merged commit ae718fb into microsoft:main Sep 29, 2021
@autoantwort autoantwort mentioned this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants