Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform-expression] add arm32 platform identifier #196

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

strega-nil
Copy link
Contributor

I've noticed people writing arm & !arm64, which just seems really unfortunate. Add an arm32 platform identifier to mean exactly this.

@autoantwort
Copy link
Contributor

autoantwort commented Sep 14, 2021

win32 would also be really cool

@BillyONeal
Copy link
Member

win32 would also be really cool

Unfortunately that one is overloaded and I think would be confusing. For example _WIN32 is a predefined macro on Windows amd64.

@autoantwort
Copy link
Contributor

Yeah that's right, I mean win32 as windows & !uwp & !mingw

@strega-nil-ms
Copy link
Contributor

@autoantwort that would be interesting, but I don't know of a good non-confusing name for it.

@autoantwort
Copy link
Contributor

Yeah win32 was the first name I can think of, because uwp is not win32. But I see that the name can be confusing, but I don't know a better one

@BillyONeal
Copy link
Member

uwp is not win32

uwp is win32. It sets _WIN32 when compiling.

@autoantwort
Copy link
Contributor

Hm ok, I am not developing on windows that much, but I thought that (parts) of the win32 API are not available on uwp so that you have to change your application when it should run on uwp.

@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Sep 14, 2021

Maybe desktop-windows-with-msvc ;)

@strega-nil-ms strega-nil-ms merged commit 733e90d into microsoft:main Sep 17, 2021
@strega-nil-ms strega-nil-ms deleted the platform-arm32 branch January 4, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants