Document the dependencies graph code #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
force-pushed
the
try-adding-documentation
branch
2 times, most recently
from
3161191 to
0e8fa97
Compare
autoantwort
changed the title
strega-nil-ms
suggested changes
Sep 7, 2021
autoantwort
force-pushed
the
try-adding-documentation
branch
2 times, most recently
from
81abdbe to
0f19e33
Compare
|
@strega-nil-ms @ras0219-msft Thank you for your help, I think I now understood how the algorithm worked :) |
autoantwort
force-pushed
the
try-adding-documentation
branch
from
0f19e33 to
7cd9c29
Compare
The function enable_default_features was only called when "core" was not in dep.features, but the function only had an effect when default_features was false, but it is only false when "core" is in dep.features. So the function does nothing at all.
Co-authored-by: nicole mazzuca <[email protected]> Co-authored-by: Robert Schumacher <[email protected]>
autoantwort
force-pushed
the
try-adding-documentation
branch
from
7cd9c29 to
3355a22
Compare
|
You can merge this now :) |
autoantwort
changed the title
# Conflicts: # src/vcpkg/build.cpp
|
Any news? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This LGTM, thanks for the code quality improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency code is imo hard to understand for new developers. 2000 lines of code without a comment. Nowhere general concepts are explained. Then there is a mixture of classic mode and manifest mode code. That nearly all functions of the class
VersionedPackageGraphhave the nameadd_constraintalso does not really help 😅 (without a debugger really hard to understand).I renamed some functions to make it easier to understand the code. The whole thing startet because I wanted to implement "default-features": false as default for host dependencies.
One of the questions currently: What is the purpose of the
FeatureSpec(PackageSpec+ one feature)? It seems that it is used to create the installation plan