Fix UB warning on OSX (#842)

* Investigate slow binary caching performance on OSX * ; * include * Fix UB & cmd test case * Remove debugging code Co-authored-by: Thomas1664 <>
microsoft · Jan 9, 2023 · a13a8de · a13a8de
1 parent 062d979
commit a13a8de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/include/vcpkg/dependencies.h b/include/vcpkg/dependencies.h
@@ -164,7 +164,7 @@ namespace vcpkg
 
         GraphRandomizer* randomizer = nullptr;
         Triplet host_triplet;
-        UnsupportedPortAction unsupported_port_action;
+        UnsupportedPortAction unsupported_port_action = UnsupportedPortAction::Warn;
     };
 
     std::vector<RemovePlanAction> create_remove_plan(const std::vector<PackageSpec>& specs,

diff --git a/src/vcpkg-test/system.cpp b/src/vcpkg-test/system.cpp
@@ -146,7 +146,7 @@ TEST_CASE ("cmdlinebuilder", "[system]")
 TEST_CASE ("cmd_execute_and_capture_output_parallel", "[system]")
 {
     std::vector<vcpkg::Command> vec;
-    for (size_t i = 0; i < 50; i++)
+    for (size_t i = 0; i < 50; ++i)
     {
 #if defined(_WIN32)
         vcpkg::Command cmd("cmd.exe");
@@ -163,7 +163,7 @@ TEST_CASE ("cmd_execute_and_capture_output_parallel", "[system]")
 
     auto res = vcpkg::cmd_execute_and_capture_output_parallel(vcpkg::View<vcpkg::Command>(vec));
 
-    for (size_t i = 0; i < res.size(); ++i)
+    for (size_t i = 0; i != res.size(); ++i)
     {
         auto out = res[i].get();
         REQUIRE(out != nullptr);