Correct overrides reference to indicate that it wants schemed versions #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s rather than strings.
|
@BillyONeal : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit ad35801: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
BillyONeal
commented
Sep 23, 2023
|
Learn Build status updates of commit 839d132: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Jan 27, 2024
We accidentally implemented the overrides deserializer to reject non-relaxed-versions in "overrides", despite the original intent that overrides are scheme-less. Note how the original schema: microsoft#1209 , and original documentation: microsoft/vcpkg-docs#159 said everything should be accepted here. Also fix our example printing when we're asking users to add overrides to ensure it is valid JSON.
BillyONeal
added a commit
to microsoft/vcpkg-tool
that referenced
this pull request
Mar 1, 2024
* Accept arbitrary version formats in overrides. We accidentally implemented the overrides deserializer to reject non-relaxed-versions in "overrides", despite the original intent that overrides are scheme-less. Note how the original schema: #1209 , and original documentation: microsoft/vcpkg-docs#159 said everything should be accepted here. Also fix our example printing when we're asking users to add overrides to ensure it is valid JSON. * Implement preferring putting the port-version into the version text. * Rename GenericVersionDeserializer to BaselineVersionTagDeserializer.
BillyONeal
added a commit
to BillyONeal/vcpkg-docs
that referenced
this pull request
Mar 2, 2024
Partially reverts microsoft#159 following the tool being changed to match the *original* docs in microsoft/vcpkg-tool#1329
AugP
pushed a commit
that referenced
this pull request
Mar 5, 2024
…282) Partially reverts #159 following the tool being changed to match the *original* docs in microsoft/vcpkg-tool#1329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/vcpkg-tool#1209