Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @service and @info to use valueof for the option bag #6108

Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Feb 21, 2025

fix #5934

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 21, 2025

All changed packages have been documented.

  • @typespec/compiler
  • @typespec/http-server-csharp
  • @typespec/http-specs
  • @typespec/http
  • @typespec/openapi
  • @typespec/openapi3
  • @typespec/rest
  • @typespec/versioning
Show changes

@typespec/compiler - feature ✏️

Migrate @service decorator options to take in a value,> ,> diff lang="tsp",> -@service({title: "My service"}),> +@service(#{title: "My service"}),>

@typespec/openapi - feature ✏️

Migrate @info decorator to expect a value,> ,> diff lang="tsp",> -@info({ version: "1.0.0" }),> +@info(#{ version: "1.0.0" }),> ,> ,> diff lang="tsp",> -@info({,> +@info(#{,> termsOfService: "http://example.com/terms/",,> - contact: {,> + contact: #{,> name: "API Support",,> url: "http://www.example.com/support",,> email: "[email protected]",> },,> }),>

@typespec/http-server-csharp - internal ✏️

Update tests and samples

@typespec/http-specs - internal ✏️

Update tests and samples

@typespec/http - internal ✏️

Update tests and samples

@typespec/openapi3 - internal ✏️

Update tests and samples

@typespec/rest - internal ✏️

Update tests and samples

@typespec/versioning - internal ✏️

Update tests and samples

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 21, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@timotheeguerin
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@timotheeguerin timotheeguerin added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@timotheeguerin timotheeguerin added this pull request to the merge queue Feb 28, 2025
Merged via the queue into microsoft:main with commit 3fe2d61 Feb 28, 2025
24 checks passed
@timotheeguerin timotheeguerin deleted the migrate/valueof-remaining branch February 28, 2025 20:03
github-merge-queue bot pushed a commit to Azure/typespec-azure that referenced this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate http and openapi decorators to use valueof
3 participants